Actually, I've been there many times and usually haven't overdone it (usually indeed ...) - though it's not difficult to indulge a bit too much there. Anyhow, I've often left the place very, very content ...You know I had to google to see what the Vaults were in Leith! Clearly I‘d be no good as a tour guide but after a trip to the Vaults you’d be too merry to care!
But seriously, I will make another trip or three to Scotland, especially the north and the Highlands, and I commonly touch down in Edinburgh because, well, it's where I've lived for a couple of months when I was studying for my CPE. My kind of town, mostly, though I found it heavily overrun by tourists the last couple of times I was there. No reason not to return, though!